PR: Fix error when running cells because previous_focused_widget is not initialized in main window #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rlaverde now that you fixed the error, please add a test to make sure we test it :-). |
ccordoba12
approved these changes
Jan 24, 2017
|
Unfortunately, I don't have time to wait for a test right now. But @rlaverde, please be sure to add a test for this in another PR :-) |
ccordoba12
changed the title
ccordoba12
added a commit
that referenced
this pull request
Jan 24, 2017
|
@ccordoba12 this would be a complex test to get running cause we need the whole app. I say we create an issue about with tech debt tag and tackle it later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4025
Sorry I introduced this error, I forget to add that variable to the
MainWindow.__init__I think was the hurry fixing #4022.