PR: Handle errors while debugging code when importing tqdm #4019
Conversation
|
I like this, good job @dalthviz! What's still missing from this PR? |
|
@ccordoba12 the thing with this is that the changes in this PR only ensure that no error is thrown. However the debug output is not correct after you run the import line, this a preview of what you see:
Also, something strange is that if you press
|
| @@ -12,10 +12,12 @@ | |||
| import ast | |||
|
|
|||
| from qtpy.QtCore import QEventLoop | |||
| from qtpy.QtWidgets import QMessageBox | |||
There was a problem hiding this comment.
This line is not needed anymore
|
|
||
| from qtconsole.rich_jupyter_widget import RichJupyterWidget | ||
|
|
||
| from spyder.py3compat import to_text_string | ||
| from spyder.config.base import _ |
There was a problem hiding this comment.
This line is also not needed now :-)
|
This is looking really good. I think the only missing thing is a test for this ;-) |
dalthviz
changed the title
dalthviz
force-pushed
the
fixes_issue_4003
branch
from
0e62ea5 to
15c9dbb
Compare
dalthviz
changed the title
| sw._append_html(_("<br>Kernel restarting because an " | ||
| "error raised while debugging " | ||
| "(stdout change)\n<hr><br>"), | ||
| before_prompt=False) |
There was a problem hiding this comment.
Please change this message to
Restarting kernel because an error occurred while debugging
There was a problem hiding this comment.
Please make this change again because it went away after I removed the test commits. Sorry.
| if sw._input_none: | ||
| sw._append_html(_("<br>Kernel restarting because an " | ||
| "error raised while debugging " | ||
| "(stdout change)\n<hr><br>"), |
There was a problem hiding this comment.
Also change this message with the same one above.
There was a problem hiding this comment.
You also need to redo this change.
ccordoba12
force-pushed
the
fixes_issue_4003
branch
from
a5b49c7 to
08ff997
Compare
|
@dalthviz, I removed all commits related to tests in this PR. The thing is this error doesn't occur on Linux, only on Windows, and we can't run tests for the main window there :-/ |
| try: | ||
| sw.kernel_manager.restart_kernel() | ||
| except RuntimeError as e: | ||
| if self.infowidget.isVisible(): |
There was a problem hiding this comment.
This whole block is indented 4 more lines than necessary. Please fix that.
| @@ -25,7 +25,8 @@ class DebuggingWidget(RichJupyterWidget): | |||
| Spyder | |||
| """ | |||
|
|
|||
| _input_reply = None | |||
| _input_reply = {} | |||
| _input_none = False | |||
There was a problem hiding this comment.
Please change this name to _input_reply_failed
| @@ -40,6 +40,7 @@ class ShellWidget(NamepaceBrowserWidget, HelpWidget, DebuggingWidget): | |||
| sig_input_reply = Signal() | |||
| sig_pdb_step = Signal(str, int) | |||
| sig_prompt_ready = Signal() | |||
| sig_debug_restart = Signal() | |||
There was a problem hiding this comment.
Please change this to sig_dbg_kernel_restart
|
@dalthviz, I left some other comments, mainly about naming conventions. Then this should be ready to be merged. I really appreciate all the effort you have put to fix this problem. What a nasty bug!! |
| @@ -283,7 +284,7 @@ def _banner_default(self): | |||
|
|
|||
| def _kernel_restarted_message(self, died=True): | |||
| msg = _("Kernel died, restarting") if died else _("Kernel restarting") | |||
| self.sig_kernel_restarted.emit(msg) | |||
There was a problem hiding this comment.
Please revert this change. This is not related to the things you're trying to solve in this PR.
| @@ -176,6 +176,9 @@ def configure_shellwidget(self, give_focus=True): | |||
| # To show kernel restarted/died messages | |||
| self.shellwidget.sig_kernel_restarted.connect( | |||
| self.kernel_restarted_message) | |||
|
|
|||
There was a problem hiding this comment.
Add a comment here explaining why this is needed.
ccordoba12
force-pushed
the
fixes_issue_4003
branch
from
c383f98 to
240edcc
Compare
|
@dalthviz, I finally managed to add tests for this, but in a different way than we had thought at the beginning :-) |
Fixes #4003
For now this only helps to prevent showing errors. However the debug function is not working properly with thetqdmimport.Now the debug function works but without showing colors.This now only handles not showing errors when importing tqdm in debug mode. Also restarts the kernel to restore the debug functionality in the current kernel.