PR: Correctly hide calltip when matching closing parenthesis #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
force-pushed
the
fixes_issue_3967
branch
from
7cc2a44 to
8f8cd5c
Compare
|
@dalthviz, this has merge conflicts. Please merge with |
ccordoba12
reviewed
Apr 11, 2017
spyder/app/tests/test_mainwindow.py
Outdated
| """Hide the calltip in the editor when a matching ')' is found.""" | ||
| # Load test file | ||
| text = 'a = [1,2,3]\n(max' | ||
| test_file = osp.join(LOCATION, 'edit_calltip.py') |
There was a problem hiding this comment.
@dalthviz, can't we get rid of this file and use instead an empty file?
|
The test you added is hanging on Linux and PyQt5. Please skip it when those conditions are met. |
|
@dalthviz, I think this is ready. The failure in CircleCI is unrelated to your work and I'm fixing it in another PR. |
ccordoba12
changed the title
ccordoba12
changed the title
ccordoba12
added a commit
that referenced
this pull request
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3967