Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Support DatetimeIndex in Variable Explorer #3849

Merged
merged 9 commits into from
Jan 8, 2017

Conversation

jitseniesen
Copy link
Member

Support variables of panda's DatetimeIndex type in variable editor, and use the dataframe editor to display them. Fixes #3380.

@jitseniesen jitseniesen added this to the v3.1 milestone Dec 17, 2016
@jitseniesen
Copy link
Member Author

I actually wrote this a while ago, while we were in freeze for the 3.0 release.

There are a number of places that have to be changed to support a new type in the variable explorer. There are also a number of issues which ask to support more types: #3758, #3562, #2824, #2510, #2355, etc. Can we make it easier to add support for a new type, possibly in a plugin?

@ccordoba12
Copy link
Member

Can we make it easier to add support for a new type, possibly in a plugin?

That's my plan for Spyder 4.0 :-) I think we could add a function called register_object to spyder/api/variableexplorer.py that would take care of doing all you've done here.

But for that we need to restructure how we dispatch objects to viewers in the Variable Explorer code, so it can be easily extended.

@ccordoba12 ccordoba12 modified the milestones: v4.0beta1, v3.1 Jan 7, 2017
@ccordoba12
Copy link
Member

@jitseniesen, this has conflicts now.

I'm leaving this for Spyder 4.0 because your PR is against master. If you want this for Spyder 3, please redo it against 3.x :-)

@jitseniesen jitseniesen changed the base branch from master to 3.x January 8, 2017 13:46
@jitseniesen
Copy link
Member Author

PR redone against 3.x and conflicts resolved.

@ccordoba12 ccordoba12 modified the milestones: v3.1, v4.0beta1 Jan 8, 2017
@ccordoba12
Copy link
Member

Thanks a lot! Just in time for 3.1 :-)

@ccordoba12 ccordoba12 changed the title Support DatetimeIndex in variable editor PR: Support DatetimeIndex in variable editor Jan 8, 2017
@ccordoba12 ccordoba12 changed the title PR: Support DatetimeIndex in variable editor PR: Support DatetimeIndex in Variable Explorer Jan 8, 2017
@ccordoba12 ccordoba12 merged commit 41954c5 into spyder-ide:3.x Jan 8, 2017
ccordoba12 added a commit that referenced this pull request Jan 8, 2017
@jitseniesen jitseniesen deleted the datetimeindex branch September 20, 2017 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants