PR: Closing tour does not freeze Spyder on windows #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goanpeca, please review this one. |
ccordoba12
reviewed
Dec 7, 2016
| @@ -917,7 +917,6 @@ def _moved(self, event): | |||
|
|
|||
| def _close_canvas(self): | |||
| """ """ | |||
| self._set_modal(False, [self.tips]) | |||
There was a problem hiding this comment.
Are there other places where _set_modal is used?
There was a problem hiding this comment.
Yes, there are #L1026-1034 in _set_data(self)
|
I'm merging this one because it fixes a very critical bug. We can revisit it later :-) |
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3452
The issue is solved. I have some comments:
self._set_modal(False, [self.tips])call when closing the tour, this affects only windows. However I am not exactly sure why it was needed before.