Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Added validation to window/position config value saved in spyder.ini #3754

Merged
merged 4 commits into from
Dec 2, 2016
Merged

PR: Added validation to window/position config value saved in spyder.ini #3754

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3d5d08
Added validation to window/position config value from .ini file
dalthviz Nov 28, 2016
1b3f465
Deleted unused sys import
dalthviz Nov 28, 2016
41cf604
Use of the validation of 'window/position' in mainwindow.py
dalthviz Dec 1, 2016
0060c93
Changed name for screen_shape variable.
dalthviz Dec 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions spyder/app/mainwindow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,6 +1319,17 @@ def load_window_settings(self, prefix, default=False, section='main'):
else:
hexstate = get_func(section, prefix+'state', None)
pos = get_func(section, prefix+'position')

# It's necessary to verify if the window/position value is valid
# with the current screen. See issue 3748
width = pos[0]
height = pos[1]
screen_shape = QApplication.desktop().geometry()
current_width = screen_shape.width()
current_height = screen_shape.height()
if current_width < width or current_height < height:
pos = CONF.get_default(section, prefix+'position')

is_maximized = get_func(section, prefix+'is_maximized')
is_fullscreen = get_func(section, prefix+'is_fullscreen')
return hexstate, window_size, prefs_dialog_size, pos, is_maximized, \
Expand Down