PR: Show time units in Profiler #3741
Conversation
|
I waiting for test for check if conflicts (on #3735) are solved now |
malliwi88
changed the title
|
@ccordoba12 is this ready? |
| @@ -510,25 +510,70 @@ def color_string(self, args): | |||
| color = "red" | |||
| return [format[0] % x[0], [diff_str, color]] | |||
|
|
|||
| def format_measure(self, data): | |||
|
|
|||
| formated_data = [0] * len(data) | ||
|
|
||
| for (i, measure) in enumerate(data): | ||
|
|
| data = [x.stats.get(child_key, [0,0,0,0,0]) for x in self.stats1] | ||
| # print(self.stats[child_key], list(zip(*data))[1:4]) | ||
| #return map(self.color_string, | ||
| # zip(list(zip(*data))[1:4], [["%i n"] * 2, ["%.3f ms", "%.3f ms"], ["%.3f", "%.3f"]])) |
There was a problem hiding this comment.
Remove these commented lines if they are not necessary anymore
| measures = data[0][4][k] | ||
|
|
||
| calls = list(measures[:1]) # measures[:2] | ||
|
|
| cum_time_dif)) = self.format_output(child_key) | ||
| (primcalls, total_calls, loc_time, cum_time, callers | ||
| ) = self.stats[child_key] | ||
| """ |
There was a problem hiding this comment.
Remove this block of commented code if it's not necessary anymore.
| child_item.setData(6, Qt.DisplayRole, total_calls_dif[0]) | ||
| child_item.setForeground(6, QColor(total_calls_dif[1])) | ||
| child_item.setTextAlignment(6, Qt.AlignLeft) | ||
| """ |
There was a problem hiding this comment.
Again, remove this if it's not necessary anymore.
|
No, it's not. There's a lot of commented (and it's seems unnecessary) code that @malliwi88 needs to decide if he wants to leave or remove. |
|
Ok @ccordoba12 your suggestions have been added and the test has passed :+1, |
| formated_data = [0] * len(data) | ||
|
|
||
| for (i, measure) in enumerate(data): | ||
|
|
|
@ccordoba12 #3672 and #3735, they are solved Now profiler is showing time units. I think that maybe it is necessary to do a little cleaning to the profiler, I found a lot of code not functional inside profiler. At the beginning the profiler looks like this: The final result looks like this: Any suggestions or corrections are welcome. |
|
@malliwi88 just focus on the problem at hand. The PR should solve the immediate and specific problem not refactor a bunch of code. |
|
|
||
| child_item.setData(2, Qt.DisplayRole, cum_time_dif[0]) | ||
| child_item.setForeground(2, QColor(cum_time_dif[1])) | ||
| child_item.setTextAlignment(2, Qt.AlignLeft) |
There was a problem hiding this comment.
What was this doing and why did you remove it?
|
|
||
| child_item.setData(4, Qt.DisplayRole, loc_time_dif[0]) | ||
| child_item.setForeground(4, QColor(loc_time_dif[1])) | ||
| child_item.setTextAlignment(4, Qt.AlignLeft) |
|
|
||
| child_item.setData(6, Qt.DisplayRole, total_calls_dif[0]) | ||
| child_item.setForeground(6, QColor(total_calls_dif[1])) | ||
| child_item.setTextAlignment(6, Qt.AlignLeft) |
|
@ccordoba12 ready 👍, You could check this. |
ccordoba12
changed the title
Fixes #3672.
Maybe it is necessary to do a little cleaning to the profiler, I found a lot of code not functional inside profiler.
The final result looks like this
