PR: Use QRegularExpression for find and replace (only for PyQt5) #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlaverde
changed the title
rlaverde
force-pushed
the
fix-lazy-regex
branch
2 times, most recently
from
987074c to
67c3ee3
Compare
- This change allows the use of lazy regular expresions - Change % formating for format() in find_text function
rlaverde
force-pushed
the
fix-lazy-regex
branch
from
a196def to
c20b7f8
Compare
|
Nice, thanks for the quick fix @rlaverde! Could you add a test for this? |
ccordoba12
reviewed
Nov 17, 2016
|
|
||
| if PYQT5: | ||
| from qtpy.QtCore import QRegularExpression | ||
| elif PYQT4: |
ccordoba12
reviewed
Nov 17, 2016
| if case: | ||
| pattern.setPatternOptions( | ||
| QRegularExpression.CaseInsensitiveOption) | ||
| elif PYQT4: |
|
Supporting this for PyQt5 if fine because we will have to eventually deprecate PyQt4 because it's not maintained anymore. |
|
@rlaverde, are you working on test for this one? |
|
LGTM, merging. Thanks @rlaverde :-) |
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #3408 (only PyQt5)
QRegExpdidn't support lazy quantifiers, like *?, +?, etc. It's better to useQRegularExpression.Although
QRegularExpressionis only avalaible since Qt5, so It'll continue usingQRegExpfor PyQT4