PR: Fix unclickable update message box

[mariacamilarg]

Fixes #3609

[goanpeca]

@mariacamilaremolinagutierrez

Awesome :-p, some advice

A title like found out what made the box unclickable is not very explanatory :-p

Something like Fix unclickable update message box or something :-p

[mariacamilarg]

I found out what what making the box unclickable. However I don't quite understand why. The box is an extension of QMessageBox called MessageCheckBox. What it does is that it situates a checkbox at the bottom on the box to know if the user whats to check updates at starup. This was not appearing before. Nos it looks like this:

The problem was that we were putting an Information icon:

box.setIcon(QMessageBox.Information)

And this for some reason that I could not figure blocks the box and disables the checkbox (it stops appearing). And looks like the user reported in the issue:

So for now and for the new release I thinks is better that it has no info icon, than that it is unclickable. However I still don't get why other methods from the super class as for example:

box.setDefaultButton(QMessageBox.Ok) box.setWindowTitle(_("Spyder updates"))

are working. This is intriguing...

[mariacamilarg]

@goanpeca I think you were working on this, do you have any idea why this setIcon() function is not working properly? Could it be is a QT problem when one generates a new class that extends from QMessageBox?

[ccordoba12]

@mariacamilaremolinagutierrez, you just removed all blank spaces from mainwindow (just to comment one line :-).

Please revert that, and just comment/remove the box.setIcon line :-)

[goanpeca]

@mariacamilaremolinagutierrez, the addition of a checkbox was a bit hackish, I think the best would be to create a new MessageBox from scratch that does not add stuff to a normal checkbox. For the moment I thin its ok to no have the info icon, but lets open an issue to keep this in the radar

[ccordoba12]

@mariacamilaremolinagutierrez, so please add a comment above the commented line saying that that line is commented because it freezes the dialog, and that it solves Issue #3609.

[mariacamilarg]

@goanpeca I agree! It is still really weird why this happens but then I'll try to make the box from scratch after I finish my other issues. Thanks :)

@ccordoba12 It has the comment now :)

[ccordoba12]

Thanks a lot @mariacamilaremolinagutierrez! Merging :-)