-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autoindentation after data structures. #3576
Fix autoindentation after data structures. #3576
Conversation
Indentation was reseting after structures defined in one line
@rlaverde, could you provide an example of the old and new behaviors? |
@rlaverde could we add a test for this behavior? |
@ccordoba12 After writing an opening and closing brackets (declaring list, dicts, or sets ...) the autoindent was wrong Old behavior: (The | is the cursor)
result:
Now:
result:
|
@goanpeca There is already a test for this marked as xfail, now It's passing, should I remove the decorator |
@rlaverde yes :-), @jitseniesen I think you were working on those tests right? |
This test was fixed in 2ffbf07
No, @Nodd was working on auto indentation. |
Since tests are passing, I just have to merge :-) Great work @rlaverde! |
@jitseniesen Yes, #1373 is like an specific case of #3214 |
Fixes #1373
When a structure is defined in the same line, the autoindent was failing