Testing: Use Qt/PyQt 5.6 packages in Travis #3340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped this message to kick Travis off again
| @@ -63,11 +66,8 @@ install_conda() | |||
|
|
|||
| install_pip() | |||
| { | |||
| if [ "$USE_QT_API" = "PyQt5" ]; then | |||
| conda install pyqt5; | |||
There was a problem hiding this comment.
@ccordoba12 is not it better, cleaner and safer to do it like this?
if [ "$USE_QT_API" = "PyQt5" ]; then
conda install pyqt=5.* qt=5.* -c qttesting;
elif [ "$USE_QT_API" = "PyQt4" ]; then
conda install pyqt=4.* qt=4.*;
fi
There was a problem hiding this comment.
Agreed. @mingwandroid, could you do these changes, please?
There was a problem hiding this comment.
I'll do these changes in PR #3338 by @mingwandroid suggestion.
| @@ -1399,3 +1399,5 @@ Since version 2.1: | |||
| * Editor/80-column vertical edge line: added options to show/hide this line and change the column number | |||
| * Editor: added "Comment"/"Uncomment" actions to context menu | |||
| * Source code and shell editor widgets: code refactoring/cleaning (this should help people using these widgets outside Spyder) | |||
|
|
|||
| Another bump | |||
There was a problem hiding this comment.
Please remove this line. @mingwandroid, you can close/reopen a PR to trigger a new build in Travis and Appveyor, instead of creating these fake commits :-)
|
Closing in favor in #3338. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your pull request be sure that:
spyderlib/defaultsdirectory.spyderlib/config/main.py.That makes our reviewing work harder and it could introduce unnecessary
conflicts with other pull requests.
icons to use to us :)
Note: You can safely remove this text before submitting your work.