Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-include plugins in setup.py packages #3300

Merged
merged 7 commits into from
Jul 26, 2016
Merged

Conversation

Nodd
Copy link
Contributor

@Nodd Nodd commented Jul 18, 2016

Fixes #3210 (comment)

I forgot this change when switching to flask model.

@goanpeca
Copy link
Member

Joselito, could you go to gitter?

@Nodd
Copy link
Contributor Author

Nodd commented Jul 18, 2016

I'm trying, but the network is really bad here so I'm not sure if it will work at all 😞

@ccordoba12
Copy link
Member

@Nodd, you also need to change this line:

https://github.com/spyder-ide/spyder/blob/master/MANIFEST.in#L2

Note: The Appveyor failure is unrelated to this change ;-)

@ccordoba12
Copy link
Member

There are also a couple of other references to spyplugins. Please remove them too.

@Nodd
Copy link
Contributor Author

Nodd commented Jul 22, 2016

I removed some preferences, and used plugins instead of spyplugins for the user directory (the wiki will have to be updated).

What's left:

  • continuous_integration/appveyor/modules_test.bat:124 : I don't know what it's doing exactly. I'm not sure that it's needed.
  • .pot and .po files : I'm not sure if I can simply use sed to update these or will it mess things up ?

@ccordoba12
Copy link
Member

continuous_integration/appveyor/modules_test.bat

I'll fix this, don't worry about it.

I'm not sure if I can simply use sed to update these or will it mess things up ?

Yeah, please use sed to update them.

@Nodd
Copy link
Contributor Author

Nodd commented Jul 23, 2016

I updated the files but the translations are not loaded. 😞

@Nodd
Copy link
Contributor Author

Nodd commented Jul 23, 2016

Everything seems to work now, except the appveyor thing.

The testing error is unrelated to my changes::

Error: HTTPError: 500 Server Error: Internal Server Error for url:
    https://repo.continuum.io/pkgs/free/linux-64/sqlite-3.13.0-0.tar.bz2
    https://repo.continuum.io/pkgs/free/linux-64/sqlite-3.13.0-0.tar.bz2

@ccordoba12
Copy link
Member

Failures seem related to internal problems with conda.

@ccordoba12 ccordoba12 closed this Jul 25, 2016
@ccordoba12 ccordoba12 reopened this Jul 25, 2016
@Nodd
Copy link
Contributor Author

Nodd commented Jul 26, 2016

No failures anymore !

@Nodd Nodd merged commit 5eab83e into spyder-ide:master Jul 26, 2016
@Nodd Nodd deleted the setup_plugins branch July 26, 2016 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants