Fix searching text in our Web widgets #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
changed the title
| @@ -185,7 +185,7 @@ def __init__(self, parent): | |||
|
|
|||
| self.webview = FrameWebView(self) | |||
| self.find_widget = FindReplace(self) | |||
| self.find_widget.set_editor(self.webview) | |||
| self.find_widget.set_editor(self.webview._webview) | |||
There was a problem hiding this comment.
Using a private variable is not good practice. Maybe just add a property to self.webview to access _webview ? This way no other code has to change.
There was a problem hiding this comment.
This was a change made by @goanpeca, so the real webview widget is saved in a private variable.
I'll write a new method to access it :-)
There was a problem hiding this comment.
Yes I remember now!, but @Nodd is ok, just add a property :-p
|
I made a few comments, mainly to simplify the code. |
Also fix an error when setting flags for WebEngine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3159