Fix bug in get encoding from "coding" comment line #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks fine but please replace Also I don't understand your example, are there missing newlines ? Or to test I can just copy-paste in an empty file in spyder ? |
|
The variable name was changed. A working example: import spyderlib
txt='return __builtins__.unicode(msg, encoding=sys.getfilesystemencoding()) except: '
coding = spyderlib.utils.encoding.get_coding(txt)
print(coding)This returns a string which is not a valid coding. |
| if codec in CODECS: | ||
| return codec | ||
| else: | ||
| return None |
There was a problem hiding this comment.
Actually if the codec is not valid, the loop should continue to the second line. It's a detail but just removing the else: block achieves that and simplifies the code.
|
Ok, changed code as suggested |
|
@eendebakpt, thanks for your contribution! |
ccordoba12
changed the title
ccordoba12
added a commit
that referenced
this pull request
Mar 5, 2016
Fix bug in get encoding from "coding" comment line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_coding function can return an encoding that is not valid. This caused spyder to crash during startup. This pull request makes sure only valid encodings are returned.
An example text which returns an invalid encoding:
# Try decoding as utf-8 bytestring return __builtins__.unicode(msg, encoding="utf-8") except: pass try: # Try guessing system default encoding and decode as such import locale return __builtins__.unicode(msg, encoding=locale.getpreferredencoding()) except: pass try: # Attempt using filesystem encoding import sys return __builtins__.unicode(msg, encoding=sys.getfilesystemencoding()) except: