Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3,5,6,7,8 spaces as options in indentation of the Editor #2888

Merged
merged 4 commits into from
Jan 23, 2016
Merged

Add 3,5,6,7,8 spaces as options in indentation of the Editor #2888

merged 4 commits into from
Jan 23, 2016

Conversation

goanpeca
Copy link
Member

Fixes #1730


Screenshot

image

@goanpeca goanpeca added this to the V3.0beta3 milestone Dec 29, 2015
@Nodd
Copy link
Contributor

Nodd commented Dec 30, 2015

Hi, I'm mister nitpick !

I'd use a qspinbox for this instead of a combobox.
If you want to keep a qcombobox i'd put them in reverse order (but with tabs still at the end).

@goanpeca
Copy link
Member Author

hey mr nitpick long time no see :)

keeping the combo, will change the order

👍

@goanpeca
Copy link
Member Author

@Nodd done

image

@Nodd
Copy link
Contributor

Nodd commented Jan 1, 2016

Maybe "Tabulation" or "Tabulations" instead of "tab" ?

@goanpeca
Copy link
Member Author

goanpeca commented Jan 2, 2016

Sure M. Nitpick, will make the change

@goanpeca
Copy link
Member Author

goanpeca commented Jan 3, 2016

image

@goanpeca
Copy link
Member Author

@ccordoba12 , @Nodd ?

@ccordoba12
Copy link
Member

LGTM 👍, merging!

@ccordoba12 ccordoba12 changed the title PR: Add 3,5,6,7,8 spaces as options in indentation of editor Add 3,5,6,7,8 spaces as options in indentation of the Editor Jan 23, 2016
ccordoba12 added a commit that referenced this pull request Jan 23, 2016
Add 3,5,6,7,8 spaces as options in indentation of the Editor
@ccordoba12 ccordoba12 merged commit 6b3c047 into spyder-ide:master Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants