-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove external dependencies #2831
Conversation
@picca and @stonebig, I want you to be aware of this change because you're the packagers I know: from now on Spyder depends on Besides, Spyder will also depend on Please review our |
@PierreRaybaut, I think you should also be aware of this change. I know you tried for a long time to make Spyder self-contained, but I decided to move away from that model to make things more flexible and easier for external contributors. |
I hope that this is true only for the v3.x series :) |
@picca, yes, of course :-) This change only applies to Spyder master (i.e. the future 3.x series), no change was done for Spyder 2.3. |
@Nodd, I think you know the Arch Linux packagers, so please inform them of this change :-) |
Do you know the license of the embeded fonts and icons. Font Awesome and Elusive Icons. |
The important point for debian is to be able to use the system font instead of your embeded copies. |
Great ! Thanks for the head-up @ccordoba12. Would it be possible to have Otherwise I have to do the transformation by hand or multiply the requirements files for pip, which is no fun. |
I fond this in Debian is it the right fonts ? Package: fonts-font-awesome |
@stonebig QtPy should be pip instalable...https://pypi.python.org/pypi/QtPy |
@goanpeca, Could you upload a wheel to help them? It should be pretty easy to generate. This is the command we use in Spyder:
I'm not sure about the command to upload it, but it should be pretty easy to google for it ;-) |
@SylvainCorlay, can @picca rely on Debian's package to provide FontAwesome instead of the one bundled with QtAwesome? |
Actually, apt-get has a different approach to js packaging (one version for everyone) from npm or bower (each project may have different version of its dependencies). Regarding the bundling of
EDIT: maybe we could do the same with debian's font-awesome. I can look at it. |
@SylvainCorlay, I have no problems regarding your plans for QtAwesome, as long as we don't need npm or bower to use the package. It's fine to have them for development purposes :-) |
@ccordoba12: the choice to keep Spyder self-consistent was fully justified when the development team was limited to... 1 people (or 2 when you joined the project). Now that there are more and more motivated people contributing to the project... and even leading the project, separating those modules from Spyder source code seems to be a good choice. |
@PierreRaybaut, it's really good to know that you also think we're moving in the right direction with this kind of changes :-) |
Just for the record, the only dependency I'm leaving is
|
Remove external dependencies
@ccordoba12 should we still make a PyPi package with a slightly different name then? |
We certainly could, if you think it's worth the effort :-) What name do you propose? |
Can you point me to the file? I have no idea what that module does |
It's in |
"lock" is not taken on pypi! |
And how it is easier? I see that this became harder. If previously I can just checkout and run, then now I have to create virtual env, cd, activate it and then run Spyder. That's suxx. |
@techtonik I just checkout and run, since I already have all the dependancies installed. And now I won't have a different behavior for my programs inside and outisde spyder because the external dependancies were not up to date... |
This PR removes libraries that we added to our tree to make Spyder self-contained. But now they are not necessary because we're relying on pip and conda to install dependencies.