Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use bootstrap on Travis #2747

Merged
merged 28 commits into from
Oct 8, 2015

Conversation

ccordoba12
Copy link
Member

  • The idea is not to use bootstrap to do our testing, but Spyder installed in a virtual or conda env.
  • This way we will detect build and/or installation errors with Travis, as the ones I have to deal with in 2.3.5.

- The idea is **not** to use bootstrap to do our testing, but Spyder
installed in a virtual or conda env.
- This way we will detect building and/or installation errors with
Travis, as the ones I have to deal with in 2.3.5.
@goanpeca
Copy link
Member

goanpeca commented Oct 8, 2015

If I am not mistaken... I was doing that originally... but somehow was removed in one of the discussions when we first implemented travis.

@goanpeca
Copy link
Member

goanpeca commented Oct 8, 2015

why did you remove the test-travis flag??

@ccordoba12
Copy link
Member Author

Because I want to call spyder (after installing it in a conda-env) instead of bootstrap.

The thing is we need to test Spyder as it's installed in site-packages and not with bootstrap, to avoid blunders as the ones I made in 2.3.5.

Right now I'm testing building and installation manually on each release and each operating system, but I'd like Travis (and later Appveyor) to help me with that :-)

@ccordoba12
Copy link
Member Author

By the way, this is just the first of a series of commits, but I want to test them all in Travis to see if I'm doing things correctly :-)

@goanpeca
Copy link
Member

goanpeca commented Oct 8, 2015

ok

@ccordoba12
Copy link
Member Author

Ok, I think this is ready. With this work we're now building, installing and testing Spyder with the help of conda and conda-build. I think this is much better than using bootstrap because (as I said) previous problems showed up during building and installation, and not with bootstrap.

Besides, these changes will also help us to start testing things with pip, once I add all our dependencies to setup.py.

@goanpeca or @blink1073, if you want to do a review, that'd be great. If not, I'll merge it tomorrow :-)

@goanpeca
Copy link
Member

goanpeca commented Oct 8, 2015

👍

@ccordoba12
Copy link
Member Author

This is not ready yet. My changes will make all PRs with merge conflicts to fail on packaging! I'm developing a better solution now :-)

@ccordoba12
Copy link
Member Author

Ok, I think this is finally ready :-)

ccordoba12 added a commit that referenced this pull request Oct 8, 2015
@ccordoba12 ccordoba12 merged commit a712a1c into spyder-ide:master Oct 8, 2015
@ccordoba12 ccordoba12 deleted the drop-bootstrap-travis branch October 8, 2015 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants