Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spyder 3 icon theme changes #2533

Merged
merged 8 commits into from
Jul 21, 2015
Merged

Conversation

SylvainCorlay
Copy link
Member

As per the suggestions in #2527.

  • IP: for the ipython logo
  • keyboard icon for the keyboard shortcuts
  • a new icon for coloring theme, it is not a palette, but an eyedropper. The advantage is that it is a font-awesome icon.
  • question-circle icon for the object inspector.

options

@SylvainCorlay
Copy link
Member Author

I have not changed the command prompt / terminal icon yet because it is used in different places, I need to be sure of what to replace.

@ccordoba12 ccordoba12 added this to the v3.0 milestone Jul 14, 2015
@ccordoba12
Copy link
Member

Great job! Any thoughts @goanpeca?

@goanpeca
Copy link
Member

Looks cool ! 👍

@SylvainCorlay
Copy link
Member Author

Now using the Python logo for the console config session as asked by Carlos. Ready to get in.

@ccordoba12
Copy link
Member

I have one suggestion: the IP: icon seems a bit too big next to text to its right. Could you make it a bit smaller?

@SylvainCorlay
Copy link
Member Author

In that instance only or all the time? The former would require adding a special entry in the icon manager, and I thought the problem with the previous one was that it was too thin...

@ccordoba12
Copy link
Member

What about this: framing the IP: symbol inside a (transparent) rectangle with the top and bottom borders a bit thicker, that represents the console? I mean, something very similar to our current IPython icon :-)

@SylvainCorlay
Copy link
Member Author

Well, that is not very "flat design" like font-awesome icons.

@ccordoba12
Copy link
Member

I don't understand what you mean. The icon would be similar to

http://fortawesome.github.io/Font-Awesome/icon/behance-square

or

http://fortawesome.github.io/Font-Awesome/icon/google-plus-square/

i.e. text inside a square (rectangle in our case) but with the colors inverted.

@ccordoba12
Copy link
Member

Another example:

http://fortawesome.github.io/Font-Awesome/icon/git-square/

Maybe we can create our IPython icon as these ones (to follow FontAwesome aesthetics :-), i.e. a white IP: over a black rectangular background.

@SylvainCorlay
Copy link
Member Author

OK, I see what you mean. I will add something like this.

@SylvainCorlay
Copy link
Member Author

@ccordoba12 done!
config

@SylvainCorlay
Copy link
Member Author

Merge?

@ccordoba12
Copy link
Member

The IPython icon is a bit blurry when used in our console tabs:

seleccion_001

Can you do something about it? I say it because the other icons look crystal clear ;-)

@SylvainCorlay
Copy link
Member Author

It is probably due to an icon size in the tabs that is not pixel perfect...

@ccordoba12
Copy link
Member

So merge? Or could you take a look at the icon size on tabs to see if we can use 16x16 icons there?

@SylvainCorlay
Copy link
Member Author

I can check, but I will be very busy this week.

@ccordoba12
Copy link
Member

Ok, merging then ;-)

ccordoba12 added a commit that referenced this pull request Jul 21, 2015
@ccordoba12 ccordoba12 merged commit 2de20fb into spyder-ide:master Jul 21, 2015
@SylvainCorlay SylvainCorlay deleted the ipython_logo branch July 22, 2015 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants