PR: [WIP] Add support for editor tab reordering #2372

goanpeca · 2015-04-27T13:07:49Z

Description

Any reordering event will reorder ALL editorstacks opened, so everything remains in sync. Since the editor was sorting by default, I disabled all instances were this was happenning, now we need to discuss what other options should we offer, including sorting and also extra ones (Delete tabs to the right, to the left, delete all tabs except this etc...)

My take on this is that new files should be opened in the order of opening (what happens now with this PR) and if the user wants to order them by some measure, it should be an active action from the user in the context menu.

The video

Todo

Make tabs moving dynamic (move tabs while dragging)
Erase sorting in preferences
Disable tab refresh when deleting a tab
Add support for tab scrolling when dragging with many tabs open (going to the right or left end should move the tabs)
Remove all code reference to fullpath sorting in the calling and creation of Editors?
Check nothing is broken!

For another PR

Offer sorting options
Offer additional options (Delete tabs to the right, to the left, delete all tabs except)?
Adapt editor preferences panel sorting options

Nodd · 2015-04-27T14:33:42Z

Yes, more tabs ! 😄

👍 for dynamic tabs (realtime moving while dragging), it's more obvious to see what happens.

ccordoba12 · 2015-04-27T15:40:59Z

This is fantastic!!! Thanks a lot for working on it! :-)

My opinions about your todos:

I agree too that new files should be opened in the order of opening. I think right now we're auto-sorting them by their path, but that's not intuitive.
This PR should also solve the issue of tab scrolling, not only when dragging but also when closing a file. I mean, there is a very annoying effect right now when closing a file and the tab scrolling buttons are on: the file you're trying to close is (automatically) made the last one from left to the right, regardless of its position. We should change that and not move tabs at all when closing files.
Let's leave new features (like new sorting options and additional options) for additional PRs. That will make my life as a reviewer much easier because I won't need to check for correctness of several things in a single PR.

goanpeca · 2015-04-27T15:47:04Z

Should I remove the option in preferences in this PR Sort files according to fullpath?

ccordoba12 · 2015-04-27T16:14:47Z

Yes, please. Let's leave new things for further PRs ;-)

Nodd · 2015-04-27T16:19:04Z

It's not a new thing, it's an old thing :)

ccordoba12 · 2015-04-27T16:40:22Z

I know, but right now I'm not so sure if the best thing is to preserve the previous behavior, and doing so by adding (yet another) option to our crowded Preferences.

But instead of discussing that here, I'd prefer to do it in another PR, so I can review and merge this one quickly :-)

goanpeca · 2015-04-27T16:42:37Z

Well.. the thing is, in this PR I commented the lines were sorting took place, so right now the option in preferences does nothing, and I would rather comment it (than erase it) so we can focus on things and move on. It would be weird to merge this PR but leave the option there.

goanpeca · 2015-04-27T16:49:20Z

You agree on the grabbing hand icon (ClosedHand) when dragging?

Or any other suggestion from here

ccordoba12 · 2015-04-27T17:05:53Z

Yes, I'd like to see the CloseHand icon when dragging.

goanpeca · 2015-04-27T18:35:07Z

@ccordoba12 I think I solved the issue you commented, but there is still another one that is quite annoying. If you have many tabs open and the scrolling buttons are there, if you click on file closer to the left, the whole tabs will shift and put the current clicked tab to the right... very weird behavior...

Nodd · 2015-04-27T18:49:27Z

Sorry for my previous comment, I was just nitpicking. I agree that the option should be removed for now (and it should be added to the context menu for tabs, this is the case where it makes sense).

goanpeca · 2015-04-27T18:57:04Z

The code in editor.py gives me headaches...

goanpeca · 2015-04-27T19:46:42Z

hmmm I think it is a Qt limitation (https://bugreports.qt.io/browse/QTBUG-2360?jql=text%20~%20%22QTabBar%20Scroll%22) that when you setCurrentIndex for a specific tab, if many tabs (and a scroll buttons present) it will always slide the selected tab to the right of the QTabBar, instead of just selecting the tab where it is.

This leads to weird behaviors when moving tabs... so the best to have here would be shortcuts to move tabs (Ctrl+Shift+PgUp/PgDn)

ccordoba12 · 2015-04-27T21:23:33Z

spyderlib/plugins/editor.py

-        fpsorting_box = newcb(_("Sort files according to full path"),
-                              'fullpath_sorting')
+#        fpsorting_box = newcb(_("Sort files according to full path"),
+#                              'fullpath_sorting')


So this was a current option? Then we should remove it in this PR because our decision is to order files according to their opening order.

Nodd · 2015-04-28T21:26:32Z

Your video examples are really cool!

I don't like the second part very much, not having the tab on the right or left end when scrolling is disturbing. The way Firefox does it is more intuitive for me: basically, you have to put the mouse pointer outside the tabbbar, then it scrolls at a given speed (faster if the mouse is further on the side).

goanpeca · 2015-04-28T21:35:30Z

@Nodd I do not understand this "not having the tab on the right or left end when scrolling is disturbing". What you suggest is harder to implement right due to the way the tabbar is designed

goanpeca · 2015-04-28T21:36:49Z

@Nodd I just checked with Firefox... I do not like it so much cause it is too fast, the user has no real control...

Nodd · 2015-04-28T21:50:23Z

es the speed is a bit too fast (I think it's needed with lots of tabs: you scroll a bit too much, the you go back 2 or 3 tabs without scrolling), but I find the principle better.
To be clear: your version is already very good. Actually I don't understand your question, do you already think about another way of doing it ?

goanpeca · 2015-04-28T21:53:12Z

I tried the firefox approach first, but I could not come up with reliable code .. then I asked the question, then I figured doing it how I did it in the video.

But now I have more tools so I can revisit the firefox version....

goanpeca · 2015-05-01T18:46:17Z

@Nodd I got it to work more like firefox (not as fast!), it is not 100% perfect (I need to look why...), but it is looking good :-)

Nodd · 2015-05-01T19:15:40Z

Nice !

goanpeca · 2015-05-04T07:58:57Z

question @ccordoba12 ...

So I have a new set of classes that will replace the existing ones so that we have an uniform support for tab handling.

But the change will include modifications to the consoles and other parts of spyder (where Tabs are used), so... should I add the new classes with the existing ones and make it work only with the editor in the meantime, and in another PR I adapt the consoles to use the new classes, (and hence erase the old classes)

I guess it would make this PR more manageable, and avoid breaking something

ccordoba12 · 2015-05-04T22:46:13Z

Yes, I agree with your plan. First use the new classes only to fix the problems we have in the Editor. Then (in another PR) use them to improve things in our consoles.

May I ask what's exactly the difference between your new classes and the old ones?

goanpeca · 2015-05-05T12:26:14Z

The actual scheme has TabBar, BaseTab, Tab.

BaseTab has no drag and drop support and is used by the editors and Tab (Which uses TabBar) has drag and drop support and is used by the consoles.

I will create a new TabBar and then a new (that uses a lot of the existing code) Tab (That will use the new TabBar), and then Tab will be used by both the editor and consoles and will allow for tab reordering (similar to Drag and drop but done in a simpler way) and also will allow for having specific contextual menus in tabs, nontabs, and even the scroll buttons (if needed).

This will also allow to completely delegate the tab reordering behavior to tabs.py so that the editor can concentrate on being an editor (different of the current code in this PR, which I will update soon)

ccordoba12 · 2015-05-05T14:41:29Z

Thanks for the explanation! Sounds really good, please proceed :-)

bbenneke · 2015-07-20T18:33:05Z

This is great! Thank you for working on this.

Is it also possible to move the tab bar to the left? Similar to Matlab, TextWrangler, Firefox, etc.?
I found that a tab bar on the left is absolutely needed if more than ~5 files are open.

See screenshot.

goanpeca · 2015-07-21T02:16:06Z

@ben1983 thanks for the input. Have you tried using the outline explorer for what you suggest?, the outline explorer displays all the opened (if you enable the functionality) files.

The feature requested will not be implemented on this pull request, but I will take note of it.

Cheers

bbenneke · 2015-07-21T17:21:33Z

@goanpeca Thank you for the quick response. Yes, I am using the outline explorer. The problems with the outline explorer are:

similar to the tab bar, one cannot change the order of the files in the outline explorer. This make repeated switching between files extremely confusing when 8-10 files are open.
when you click on a file in the outline explorer, the outline explorer always open the tree view and shows all the function and loops within that file. If you have >20 functions and loops in one file (which is totally common), all the other files are moved to the bottom off the screen. Switching back and forth becomes a hassle. My suggestions would be: 1) single click to change to the selected file without opening the tree view, 2) double click on a file to open the tree displaying the functions within that file.
Is that hard to implement?

ccordoba12 · 2015-08-11T02:01:36Z

This needs a rebase, and I think it's really important to finish it :-)

oldrichsmejkal · 2016-06-24T18:36:31Z

What about this issue? It's pretty old, and it would be nice to have this features...

Thanks.

ccordoba12 · 2016-07-23T16:39:00Z

Closing because @goanpeca has a different approach to solve this. It'll be fixed in 3.1 ;-)

Add support for editor tab reordering

dd037e7

goanpeca added type:Enhancement component:Editor User Interface (UI) labels Apr 27, 2015

goanpeca self-assigned this Apr 27, 2015

goanpeca added this to the v3.0 milestone Apr 27, 2015

goanpeca mentioned this pull request Apr 27, 2015

Editor: drag n' drop (movable) tabs #564

Closed

Add support for dynamic tab moving

0398e71

Remove sort option in preferences

56ca04f

ccordoba12 reviewed Apr 27, 2015
View reviewed changes

goanpeca mentioned this pull request May 7, 2015

Reduce the "chrome" #2353

Closed

goanpeca changed the title ~~[WIP] Add support for editor tab reordering~~ PR: [WIP] Add support for editor tab reordering Jan 27, 2016

ccordoba12 modified the milestones: v3.0beta4, v3.0 Jan 27, 2016

ccordoba12 modified the milestones: v3.0beta4, v3.0rc1 Apr 25, 2016

ccordoba12 modified the milestones: v3.0beta4, v3.0rc1 Jun 9, 2016

ccordoba12 removed this from the v3.0beta5 milestone Jul 23, 2016

ccordoba12 closed this Jul 23, 2016

rlaverde mentioned this pull request Jan 10, 2017

PR: Make Editor tabs movable #3946

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: [WIP] Add support for editor tab reordering #2372

PR: [WIP] Add support for editor tab reordering #2372

goanpeca commented Apr 27, 2015 •

edited by ccordoba12

Loading

Nodd commented Apr 27, 2015

ccordoba12 commented Apr 27, 2015

goanpeca commented Apr 27, 2015

ccordoba12 commented Apr 27, 2015

Nodd commented Apr 27, 2015

ccordoba12 commented Apr 27, 2015

goanpeca commented Apr 27, 2015

goanpeca commented Apr 27, 2015

ccordoba12 commented Apr 27, 2015

goanpeca commented Apr 27, 2015

Nodd commented Apr 27, 2015

goanpeca commented Apr 27, 2015

goanpeca commented Apr 27, 2015

ccordoba12 Apr 27, 2015

Nodd commented Apr 28, 2015

goanpeca commented Apr 28, 2015

goanpeca commented Apr 28, 2015

Nodd commented Apr 28, 2015

goanpeca commented Apr 28, 2015

goanpeca commented May 1, 2015

Nodd commented May 1, 2015

goanpeca commented May 4, 2015

ccordoba12 commented May 4, 2015

goanpeca commented May 5, 2015

ccordoba12 commented May 5, 2015

bbenneke commented Jul 20, 2015

goanpeca commented Jul 21, 2015

bbenneke commented Jul 21, 2015

ccordoba12 commented Aug 11, 2015

oldrichsmejkal commented Jun 24, 2016

ccordoba12 commented Jul 23, 2016

PR: [WIP] Add support for editor tab reordering #2372

PR: [WIP] Add support for editor tab reordering #2372

Conversation

goanpeca commented Apr 27, 2015 • edited by ccordoba12 Loading

Description

Todo

Nodd commented Apr 27, 2015

ccordoba12 commented Apr 27, 2015

goanpeca commented Apr 27, 2015

ccordoba12 commented Apr 27, 2015

Nodd commented Apr 27, 2015

ccordoba12 commented Apr 27, 2015

goanpeca commented Apr 27, 2015

goanpeca commented Apr 27, 2015

ccordoba12 commented Apr 27, 2015

goanpeca commented Apr 27, 2015

Nodd commented Apr 27, 2015

goanpeca commented Apr 27, 2015

goanpeca commented Apr 27, 2015

ccordoba12 Apr 27, 2015

Choose a reason for hiding this comment

Nodd commented Apr 28, 2015

goanpeca commented Apr 28, 2015

goanpeca commented Apr 28, 2015

Nodd commented Apr 28, 2015

goanpeca commented Apr 28, 2015

goanpeca commented May 1, 2015

Nodd commented May 1, 2015

goanpeca commented May 4, 2015

ccordoba12 commented May 4, 2015

goanpeca commented May 5, 2015

ccordoba12 commented May 5, 2015

bbenneke commented Jul 20, 2015

goanpeca commented Jul 21, 2015

bbenneke commented Jul 21, 2015

ccordoba12 commented Aug 11, 2015

oldrichsmejkal commented Jun 24, 2016

ccordoba12 commented Jul 23, 2016

goanpeca commented Apr 27, 2015 •

edited by ccordoba12

Loading