-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Always use utf-8
when handling QByteArray data in ProcessWorker
(Utils)
#22656
Conversation
@dalthviz, could you check that our |
utf-8
when handling QByteArray data in ProcessWorker
utf-8
when handling QByteArray data in ProcessWorker
(Utils)
Checked using Spyder 6.0.1 from the Windows installer and also this PR with a project called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 ! Left a comment related with that maybe it could be worthy to add some sort of context of why now the function should always return utf-8
. Also, maybe is worthy to add some sort of test for this? I'm unsure what is needed to reproduce the issue this fixes but probably having a test should ensure the change done here is enough
Ok, thanks for checking @dalthviz. Maybe the problem only appears for computers with a proper Windows Chinese version. In any case, the user that reported issue #22546 verified that this correctly fixes it for them. |
9d2005a
to
06cdfeb
Compare
06cdfeb
to
4389853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 !
@meeseeksdev please backport to 6.x |
…yteArray data in `ProcessWorker` (Utils)
…656-on-6.x Backport PR #22656 on branch 6.x (PR: Always use `utf-8` when handling QByteArray data in `ProcessWorker` (Utils))
Description of Changes
fzf
.Issue(s) Resolved
Fixes #22546.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: