-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PR: Update contributing, release and maintenance instructions for backporting #22442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update contributing, release and maintenance instructions for backporting #22442
Conversation
c60f43c
to
1668b38
Compare
@dalthviz, this is ready for review. |
Give a quick check and makes sense to me 👍 Left only a single comment related with the management of the alpha part over the version update. Also, thinking about docs updates. Could this PR be a good place to update the README badges that launch binder instances? Not sure if there are other places where 5.x is still being mentioned 🤔 |
Also, update instructions to release stable versions.
With backporting is not easy to count the commits between two tags, so we can't report them anymore.
1668b38
to
c7da849
Compare
I'll leave that for another PR to include a critical fix to avoid hard freezes on Binder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 ! LGTM 👍 Following the updated steps, after this gets merged, this should be backported to 6.x, right?
Also, is there any other change you want to add here or should I proceed with the merge?
Correct. If a PR is marked for 6.0.x, 6.1.x, etc, it needs to be backported.
Nop, this is ready. By the way, I'm using regular merges in master to preserve the commit history, but squash merges in 6.x because history is not so critical there. And I'm planning to add another bot to automatically do that in 6.x. |
@meeseeksdev please backport to 6.x |
…intenance instructions for backporting
Is there a case where you will need to merge something directly to 6.x without passing from master and the backporting procedure (which seems like creates a PR with a single commit)? |
…442-on-6.x Backport PR #22442 on branch 6.x (PR: Update contributing, release and maintenance instructions for backporting)
There should be very few things that only apply to |
Description of Changes
This not only simplifies our workflow by avoiding the need to manually forward-port PRs from the stable branch to master. It'll also help us to maintain a more stable branch, by only backporting what we think is really necessary.
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12