-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fix listing envs in the Consoles' environment menu (IPython console) #22380
Conversation
Consoles > New console in environment
menu (IPython console)a0e8d98
to
59b0978
Compare
@mrclary, could you check that this PR fixes the problem I mentioned in the OP for the Windows and Mac installers? For that you only need to copy/paste |
Ok, this doesn't look good and thanks for mentioning it. I can make the necessary adjustments to show a better name for that env. What name do you propose? I think Edit: Sorry, it should simply be |
That is correct. I recommend the following changes: |
Also, improve when we consider an env to be Conda when it's not autodetected.
Without this the combobox appears too small when there are no additional interpreters.
…n envs menu - That'll make things consistent with the "New console" action. - Also, use functools.partial for the other env actions because it's more Pythonic.
8f55195
to
d238a4c
Compare
d238a4c
to
847f43c
Compare
@mrclary, this should be ready now, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @ccordoba12!
@ccordoba12, do you want to rebase before merging or just merge? |
I'll merge because I already squash-merged your PR. |
Description of Changes
cryptography
warnings at startup.is_conda_based_app
because that's a critical function now.Visual changes
Before
After
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12