Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix redirection flag for micromamba (IPython console) #22360

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Aug 19, 2024

Description of Changes

micromamba does not recognize the redirection flag --live-stream (--no-capture-output). However, its equivalent flag is --attach ""

Issue(s) Resolved

Fixes #22240

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@mrclary mrclary self-assigned this Aug 19, 2024
@mrclary mrclary added this to the v6.0rc2 milestone Aug 19, 2024
@mrclary
Copy link
Contributor Author

mrclary commented Aug 19, 2024

@ccordoba12, I was able to reproduce the error in #22240, and confirmed that this PR fixes it.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary! Just some suggestions about comments for you.

spyder/plugins/ipythonconsole/utils/kernelspec.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/utils/kernelspec.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title PR: Fix redirection flag for micromamba PR: Fix redirection flag for micromamba (IPython console) Aug 19, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 871def3 into spyder-ide:master Aug 20, 2024
14 checks passed
@mrclary mrclary deleted the issue-22240 branch August 20, 2024 04:31
@jhaskinsPhD
Copy link

Stumbled onto this after facing similar issues getting spyder to launch from inside a micromamba installation to find the pull request was merged last week. Is the updated fix available on the conda-forge channel yet for installation? I'm not familiar with installing dev versions from GitHub directly, but downgrading to v5.5.5 did not work for me.

@mrclary
Copy link
Contributor Author

mrclary commented Aug 29, 2024

Stumbled onto this after facing similar issues getting spyder to launch from inside a micromamba installation to find the pull request was merged last week. Is the updated fix available on the conda-forge channel yet for installation? I'm not familiar with installing dev versions from GitHub directly, but downgrading to v5.5.5 did not work for me.

@jhaskinsPhD, this PR addresses an issue for our yet-to-be-released 6.0 version of Spyder being able to interact with external environments when the main conda executable is micromamba, and should not affect launching Spyder. If you are unable to launch Spyder from a micromamba environment, will you please open a new issue so that we can address your specific situation?

@jhaskinsPhD
Copy link

I should clarify...

I was able to launch the latest release of spyder downloaded via conda-forge this week from a new micromamba (v1.5.8) environment installed on a linux x64 machine, but I got the identical spyder kernels error that issue #22240 raised with the Ipython kernel not functioning/ being able to load and got here by googling around on the error. I initially tried downgrading to spyder v5.5.5 as suggested by the other users encountering the error, but that didn't work. Subsequently, I tried copying over your commits to see if they fixed my issues, but that made more errors since I didn't pull the other updates too & since this style of dev is pretty beyond my skill level, I stopped messing with it. So, I deleted that env, made a new one, and tried installing spyder v5.4.5 in that fresh env, which actually did address my spyder-kernels issue in the Ipython console since I last posted. So, I don't think this is a separate issue I was encountering, but if you think it is, I'm happy to raise a new issue and do a full description of my setup/issue.

I should also note, I was playing around with miniforge3 as well and actually encountered the same error trying to launch the most recent version of spyder in a new environment on that distribution, which makes me think its more of a spyder issue than a micromamba/miniforge3 issue.

@mrclary
Copy link
Contributor Author

mrclary commented Aug 31, 2024

I should clarify...

@jhaskinsPhD, thanks for the clarification. While it may be similar to (or the same as) #22240, I think it will be best to open a new issue. I want to be sure to identify your problem explicitly with confusing your setup with anyone else's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spyder 6.0.0b2 consoles fail to start with micromamba
3 participants