PR: Update custom button tab index when removing intermediate tabs without changing current selected tab (Widgets) #22292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
A tab removal makes the following ones to change their
index
(<new index> = <old index> - 1
). Following that, there is a need to update theindex
attribute that the custom close button instances have. Otherwise, aIndexError
(in the case of the Editor) can be raised. This fix also prevents raising anAttributeError
when doing a similar interaction with IPython Console client tabs:Issue(s) Resolved
Fixes #22033
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz