PR: Tabify Outline next to Projects in default layout and other layout improvements and fixes #22232
Conversation
|
@dalthviz, this is ready for review. |
| # Save layout before closing all plugins. This ensures its restored | ||
| # correctly in the next session when there are many IPython consoles | ||
| # open in the current one. |
There was a problem hiding this comment.
I think this change makes saving the layout more robust.
ccordoba12
force-pushed
the
dock-outline-with-projects
branch
from
058f5c2
to
4020817
Compare
`virtualGeometry` gives the geometry of the all screens combined instead of the current one (which is given by `geometry`).
That allows the call to resizeDocks to work as expected.
- It'll be docked along with Projects. - Also, change the proportion of areas in that layout so that Projects and the Outline don't appear too thin.
ccordoba12
force-pushed
the
dock-outline-with-projects
branch
from
44032a0
to
c809a4a
Compare
|
Checking this I noticed the following (although not completely sure if the changes here are the cause and some are just ideas/questions that occured to me):
|
ccordoba12
force-pushed
the
dock-outline-with-projects
branch
from
c809a4a
to
86f4878
Compare
Also, dock all plugins before saving the layout to avoid an old bug.
This is necessary now that we set the layout when the main window is visible.
ccordoba12
force-pushed
the
dock-outline-with-projects
branch
from
86f4878
to
923e71a
Compare
|
Thanks for the additional review @dalthviz! About your comments:
Great catch! I didn't test that when moving the Outline to the left but it should be fixed now.
Great catch too! I was easily able to reproduce this by simply closing the main window when is not maximized. The solution was to restore the code to apply the layout twice: before and after the main window is visible (in my previous solution I though it was necessary to apply it only after). So, the fix you provided for issue #17945 was almost right, but in order to address issue #21596, the second time the layout is applied needs to happen after the
Fixed in my last commit.
I addressed that in my last commit too.
The errors on CI were happening because I removed the code that applied the layout before the main window is visible. And I decided to fix #22178 here because while looking at the CI logs I saw that many tests were flagged as having errors due to that issue. |
Also, skip warning shown when using PyQt6 and change translatable name of default layout.
ccordoba12
force-pushed
the
dock-outline-with-projects
branch
from
923e71a
to
a815b2f
Compare
There was a problem hiding this comment.
Thanks @ccordoba12 ! Gave this last check and seems like things are working as expected. Left a couple of comments but I will leave this PR approved so feel free to merge it when you think is ready 👍
Also, on an, I think, unrelated note, while checking this I started to notice that the options menus of the plugins panes need to be requested two times for them to render correctly 🤔 I don't think that is related with the work on this PR but seemed a behavior worthy of mention:
Thanks! I addressed them in my last commit.
Are you observing that with PyQt 5 or 6? I can easily reproduce it with Qt 6 but not with 5. If that's the case for you too, we should leave it for later (but please open an issue about it). |
I'm able to see the behavior with PyQt5 using master. My setup info:
|
|
Ok, if the problem is visible in master, it means it's not related to this PR. So, please open a new issue about it and tag it for rc1. |
Description of Changes
bootstrap.py. I did this to test that the fix to position Spyder in the right screen worked for both Qt5 and 6.EditorMainWidgetone. That's in case the latter is too small.Issue(s) Resolved
Fixes #22178
Fixes #21596
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12