Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix callable associated to restart_action (IPython console) #22085

Merged
merged 1 commit into from
May 16, 2024

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented May 16, 2024

Description of Changes

Issue(s) Resolved

Fixes #22084

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

Also, expand test suite to check that action is working as expected.
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 ! Checked locally and seems like things are now working as expected for the restart kernel action 👍 However, seems like now a test related with the interactive backend is failing (https://github.com/spyder-ide/spyder/actions/runs/9105002468/job/25052184772?pr=22085#step:15:5891)?

Currently trying to check locally what could be causing that but seems like the failing test is marked as not meant to be run on Windows 🤔

@ccordoba12
Copy link
Member Author

ccordoba12 commented May 16, 2024

However, seems like now a test related with the interactive backend is failing

Yep, I think that's caused by the release of Matplotlib 3.9, which was done yesterday. Since it's not available yet in Conda-forge (see conda-forge/matplotlib-feedstock#373), it won't affect our installers.

If we want to release 6.0 final in June, I think it's best to release beta1 now with this small error and fix it in beta2, which should be ready in two weeks at most.

@ccordoba12 ccordoba12 merged commit 27e00ab into spyder-ide:master May 16, 2024
13 of 14 checks passed
@ccordoba12 ccordoba12 deleted the issue-22084 branch May 16, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when restarting kernel
2 participants