PR: Additional UI/UX improvements for Files and Projects #21813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this we were not showing the pointing hand cursor on top of rows for Python versions equal or greater than 3.10
- What we really need in other places is the constant instead of the function. - Use it instead of the function where it was called.
- That's much faster because is_text_file needs to open a file to detect if it's editable or not. - That should prevent freezes when browsing large directories in the Files plugin.
That's not really necessary.
- Those are files left by git from failed merges. - Also, fix code style a bit.
Also, skip warning due to our splash screen and don't print blacklisted warnings in dev mode because they can be annoying.
This is a follow up after PR spyder-ide#21666 was merged.
|
Hello @ccordoba12! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
I already discussed these changes with the UX team and they agree with them. So, I'm going to merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
chardetfor binary detection is slow..origfiles from view in Projects. Those are generated by git when a merge fails so we don't really need to display them.Visual changes
Issue(s) Resolved
Part of #10081.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12