PR: Use UTF-8 by default for Python files per PEP3120 #21804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jitseniesen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-02-18 20:28:45 UTC |
ccordoba12
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Thanks @jitseniesen for working on this one! I left a tiny suggestion for you, the rest looks good to me.
|
Also, please address the problems reported by pep8speaks above. |
jitseniesen
force-pushed
the
encoding
branch
from
1763acf
to
6650e66
Compare
This PR changes how Spyder determines the encoding of files opened in the editor to ensure that we follow PEP3120. For Python files without a declaration of the form "coding=xxx", use UTF-8 as encoding. For other files, we use the chardet library as before. For the purpose of this PR, Python files are those with one of the following extensions: .py, .pyw or .ipy . Also add tests for the new functionality.
This is the extension used by Python type stub files.
jitseniesen
force-pushed
the
encoding
branch
from
6650e66
to
67694ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR changes how Spyder determines the encoding of files opened in the editor to ensure that we follow PEP3120.
For Python files without a declaration of the form
coding=xxx, use UTF-8 as encoding. For other files, we use the chardet library as before.For the purpose of this PR, Python files are those with one of the following extensions:
.py,.pywor.ipy. This is taken from https://github.com/spyder-ide/spyder/blob/master/spyder/utils/misc.py#L211-L213.Also add tests for the new functionality.
I made this PR as small as possible because we are close to Spyder 6, but the file "encoding.py" can probably be cleaned up a bit. Some code feels like Python 2, with the distinction between text and binary strings. The functions
get_coding()andread()have parameters that do not seem to be used.There is related discussion in issue #20510. In particular, this PR fixes the problem noted in #20510 (comment).
Issue(s) Resolved
Fixes #17807
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
Jitse Niesen