Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Avoid conda run capturing output in env activation (IPython console) #21788

Merged
merged 8 commits into from
Feb 11, 2024

Commits on Feb 10, 2024

  1. IPython console: Avoid "conda run" capturing output in env activation

    - That restores capturing output from external processes and printing
    segfaults to the console.
    - Also, fix test_print_faulthandler because it started to fail due to
    env activation for the default env.
    ccordoba12 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    7783e34 View commit details
    Browse the repository at this point in the history
  2. IPython console: Don't use cached kernel if it failed to start

    - That allows to show our kernel error message in every client connected
    to a conda environment that didn't start.
    - Also, update comment in test_kernel_crash accordingly.
    ccordoba12 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    a72beef View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Configuration menu
    Copy the full SHA
    c408f42 View commit details
    Browse the repository at this point in the history
  2. Projects: Disable pdb_prevent_closing before opening/closing project

    This fixes loading the project's session files or the ones in the
    previous session if a console was left in debugging mode.
    ccordoba12 committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c6d3182 View commit details
    Browse the repository at this point in the history
  3. IPython console: Stop debugging before closing clients

    This prevents freezes when closing Spyder and either a kernel restart or
    closing a client is requested while debugging.
    ccordoba12 committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    289f7af View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8e5a72f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    39b10b1 View commit details
    Browse the repository at this point in the history
  6. IPython console: Remove on_close method from it main widget

    That's not really necessary because the plugin declares the same method,
    so it was being called twice when the main window is closed.
    ccordoba12 committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    86649d2 View commit details
    Browse the repository at this point in the history