PR: Improve performance of workspace watcher (Projects) #21762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's not really necessary.
- That way we avoid flooding the LSP server with too many requests. - Also, fix test that checks the watcher functionality and remove usage of to_text_string in it.
That's because it's more performant on Linux and behaves better on Windows. It seems there are no issues with the current observer on Mac, but I think it's better to have a single solution for all OSes.
|
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-02-02 22:18:23 UTC |
- We also ignore some especial folders like __pycache__ and build. - Expand test_filesystem_notifications to cover those cases.
ccordoba12
force-pushed
the
workspace-watcher-performance
branch
from
1a9430c
to
da32384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
__pycache__andbuildfrom the watcher too.Issue(s) Resolved
Part of #10664.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: