PR: Fix several UI regressions and errors #21707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a visual bug in the Preview editor of the Appearance config page: when switching themes the current line highlighting was not being updated.
This makes the scrollbar feel as part of that widget.
It was off by one pixel.
- Prevent showing two editors when doing double clicks in lists, dataframes, etc. - Make dialogs be focused after doing double clicks to not force current users change their muscle memory.
- That was interfering with displaying the right padding for menu items (don't know why). - Move the two styles declared on it to their respective widgets. This also fixes setting up the right icon size for context menus, which was not working. - Simplify applying stylesheet to the main window.
|
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-01-15 14:54:37 UTC |
Also, fix vertical repositioning on Mac.
This was preventing to set the shortcuts for copy absolute/relative path in Projects because they are the same ones in Files.
ccordoba12
force-pushed
the
ui-regressions
branch
from
e58c7b0
to
76deb7f
Compare
- Reduce min width of its path selection and exclude comboboxes so they are collapsed at a much smaller size. - Make its items width be the widget's one if the longest item is shorter than it. - Recompute items width when the widget is resized so the UI is rendered as expected.
ccordoba12
force-pushed
the
ui-regressions
branch
from
76deb7f
to
c724839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
findChildren(QTabBar), which takes a long time now (probably due to the new style for special tabbars). To fix that, we call that method with a timer every minute in the main window, which avoids the freeze.SpyderMenu.SpyderMenuandSpyderComboBox.Visual changes
Fix incorrect padding of menu items for some menus
This was due to our global proxy style
Fix highlight color of current line when selecting different color schemes in Preferences
Make contents area scrollbar background color match its parent's one
Make width of Find items be the widget's one if the longest item is shorter than it.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12