Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Make some UI/UX improvements to the Find pane #21622

Merged
merged 6 commits into from
Dec 20, 2023
Merged

PR: Make some UI/UX improvements to the Find pane #21622

merged 6 commits into from
Dec 20, 2023

Commits on Dec 16, 2023

  1. Find: Avoid error when path attributes are None in SearchInComboBox 

    This was generating a traceback when passing one of those paths to the
search thread.
    @ccordoba12
    ccordoba12 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    df2ef26 View commit details
    Browse the repository at this point in the history

  2. Find: Change text of Find in Files action 

    This is useful to help users better understand how this action works.
    @ccordoba12
    ccordoba12 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    7ec0274 View commit details
    Browse the repository at this point in the history

  3. Find: Remove tooltips from the SearchInComboBox entries 

    They are unnecessary and annoying.
    @ccordoba12
    ccordoba12 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    7f133eb View commit details
    Browse the repository at this point in the history

  4. Find: Use an enum for the indexes used in SearchInComboBox 

    That will allow us to reference them more easily.
    @ccordoba12
    ccordoba12 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    6041f89 View commit details
    Browse the repository at this point in the history

  5. Find: Change state of some items when dirs are added/removed to/from … 

    …SearchInComboBox
    @ccordoba12
    ccordoba12 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    d294817 View commit details
    Browse the repository at this point in the history

  6. Find: Leave results_browser visible after first search is performed 

    This avoids showing the pane_empty widget when no results have been
found.
    @ccordoba12
    ccordoba12 committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    1ca7003 View commit details
    Browse the repository at this point in the history