PR: Add new options for font size and bottom edge for inline plot #21566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jitseniesen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-01-02 19:26:41 UTC |
jitseniesen
force-pushed
the
plot-options
branch
from
54c62ce
to
0464320
Compare
|
The force-push was to fix a PEP8 style violation. |
jitseniesen
changed the title
ccordoba12
reviewed
Dec 30, 2023
There was a problem hiding this comment.
Thanks @jitseniesen for your work on this! Small small code style suggestions for you, the rest looks good to me.
Also, please resync our subrepo now that I merged your PR there.
spyder/plugins/variableexplorer/widgets/tests/test_namespacebrowser.py
Outdated
Show resolved
Hide resolved
As suggested in code review. Co-authored-by: Carlos Cordoba <[email protected]>
…r-kernels.git --branch=master --update --force external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "66576a716" upstream: origin: "https://github.com/spyder-ide/spyder-kernels.git" branch: "master" commit: "66576a716" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "110b9eb"
jitseniesen
force-pushed
the
plot-options
branch
from
4a0f8f2
to
f5b92b7
Compare
Done, this should be good to go now if the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add two new options, for the font size and the position of the bottom edge, for inline plots in the IPython console. The reason for this was discussed in issue #19672. Send these options to the Spyder kernels, where they will be used in a partner PR (I hope I'm doing that right, I have never done this before).
When writing the code, I noticed that the (?) icons for the tooltips of some spinboxes (resolution, width, height) was missing, so I added these as well.
The Preferences page now looks like this:
For comparison, this is what it looks before the PR:
Issue(s) Resolved
Fixes #19672
Depends on spyder-ide/spyder-kernels#477
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: Jitse Niesen