Skip to content

PR: Temporarily use Apple Developer ID Application Certificate for signing Windows installer #21391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Oct 2, 2023

Description of Changes

Use Apple Developer ID Application Certificate for signing Windows installer.
Eventually, a different certificate will be required for full Windows security compliance.

Issue(s) Resolved

Partially addresses #21389

@mrclary mrclary self-assigned this Oct 2, 2023
@mrclary mrclary requested a review from ccordoba12 October 2, 2023 17:42
@mrclary mrclary marked this pull request as ready for review October 2, 2023 17:42
@ccordoba12
Copy link
Member

Thanks @mrclary for your work on this! I just have one question for you: what happens if you try to install our Windows app after this change? Does it get rejected by Windows?

@mrclary
Copy link
Contributor Author

mrclary commented Oct 2, 2023

@ccordoba12, I'll run a workflow dispatch as pre in order to sign it and compare it to the artifact from run 1704 and report back.

@mrclary
Copy link
Contributor Author

mrclary commented Oct 2, 2023

Hmm...
I did not get any security pop-up windows when installing signed or unsigned installers, nor when opening Spyder from these installations. My company laptop running a Windows VM should be catching the unsigned at least; this has happened in the past.

If anyone else wants to try them:

@ccordoba12
Copy link
Member

Ok, so you think it's safe to merge this one?

@mrclary
Copy link
Contributor Author

mrclary commented Oct 4, 2023

@ccordoba12, I think it is safe to merge; I just don't know if it changed the behavior of the Windows installer.

@ccordoba12
Copy link
Member

Ok, let's merge then.

@ccordoba12 ccordoba12 added this to the v6.0alpha3 milestone Oct 4, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 84ba0ca into spyder-ide:master Oct 4, 2023
@ccordoba12
Copy link
Member

@dalthviz, we'd appreciate your input when you have time to check if the Windows installer behavior changed thanks to this PR.

@dalthviz
Copy link
Member

dalthviz commented Oct 4, 2023

So checking the generated executable with the Apple certificate I see this the first time I execute it:

image

Also checking the file properties I can see this:

image

I guess since is not a Windows certificate is not recognized unless the user manually installs it/set it as valid?

Just in case, regarding the installer behavior (regardless of certificate), depending on the type of installation (for the current user or the whole system) you will get prompt to run with admin privileges or not (a little shield is added to the next button):

imageimage

@mrclary mrclary deleted the issue-21389-sign-windows branch October 4, 2023 22:14
@mrclary
Copy link
Contributor Author

mrclary commented Oct 5, 2023

Also checking the file properties I can see this:
...
I guess since is not a Windows certificate is not recognized unless the user manually installs it/set it as valid?

Yes, I think this is the expected behavior. The certificate will not satisfy Windows security protocol, but at least users can see the info and know who it is coming from. We will need to get a different certificate for Windows; but at least the signing process seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants