Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add an empty message to the Debugger pane #21352

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

conradolandia
Copy link
Contributor

@conradolandia conradolandia commented Sep 19, 2023

Description of Changes

  • Added icons for panes: console-off, console-remote-off, debugger and dependencies.
  • Added widget to show empty pane in debugger while no debugging sessions are active.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@conradolandia

image

@pep8speaks
Copy link

pep8speaks commented Sep 19, 2023

Hello @conradolandia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-09-27 03:43:41 UTC

@conradolandia conradolandia marked this pull request as ready for review September 19, 2023 23:21
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @conradolandia for your work on this! The code looks good to me, but we still need to improve the text that'll be displayed when no debugging session is active.

spyder/plugins/debugger/widgets/framesbrowser.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v6.0alpha3 milestone Sep 20, 2023
@ccordoba12 ccordoba12 changed the title PR: Add an empty message to the Debugger pane Add an empty message to the Debugger pane Sep 27, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @conradolandia for your work on this!

@ccordoba12 ccordoba12 merged commit fa82bca into spyder-ide:master Sep 27, 2023
16 checks passed
@ccordoba12 ccordoba12 changed the title Add an empty message to the Debugger pane PR: Add an empty message to the Debugger pane Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants