PR: Fix issues for all-user install in post-install script (Installers) #21053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quote variable interpolation in conditional statements and check for file not just exists. Remove aliases before environment in uninstall. Set executable permission for user only for uninstall-spyder.sh. Only add aliases if shell_init is not null. Use relative path in shortcut command for macOS to allow Spyder.app to be moved.
ccordoba12
changed the title
ccordoba12
changed the title
ccordoba12
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uninstall-spyder.sh.shell_initis not null.menuinstcurrently puts shortcut in~/Applicationsinstead of/Applicationsfor all-user install.