Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Improve and refactor the way we run and debug code in the IPython console #20726

Merged
merged 14 commits into from
Mar 31, 2023
Merged

PR: Improve and refactor the way we run and debug code in the IPython console #20726

merged 14 commits into from
Mar 31, 2023

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Mar 24, 2023 •
edited by ccordoba12
Loading

Description of Changes

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Quentin Peter added 2 commits March 24, 2023 06:56
fix tests
f9741d4
git subrepo clone --branch=profile_script --force https://github.com/…
31ef433 
…impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "c34dc8ff0"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "profile_script"
  commit:   "c34dc8ff0"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
@ccordoba12 ccordoba12 mentioned this pull request Mar 29, 2023
Merged
@ccordoba12 ccordoba12 changed the title Test https://github.com/spyder-ide/spyder-kernels/pull/286 without profiler plugin PR: Improve and refactor the way we run code in the IPython console Mar 29, 2023
@ccordoba12 ccordoba12 added this to the v6.0alpha1 milestone Mar 29, 2023
@ccordoba12
Copy link
Member

I think we should merge this one before merging PR #15372 because it contains an important refactoring in Spyder-kernels not related to the profiler functionality.

ccordoba12
ccordoba12 reviewed Mar 29, 2023
View reviewed changes
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/debugging.py Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/debugging.py Outdated Show resolved Hide resolved
spyder/plugins/ipythonconsole/widgets/debugging.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title PR: Improve and refactor the way we run code in the IPython console PR: Improve and refactor the way we run and debug code in the IPython console Mar 29, 2023
impact27 and others added 4 commits March 30, 2023 07:07
@impact27
Copy link
Contributor Author

I think we should merge this one before merging PR #15372 because it contains an important refactoring in Spyder-kernels not related to the profiler functionality.

Ok, thanks for the nice review!

Quentin Peter added 4 commits March 30, 2023 07:23
git subrepo clone --branch=profile_script --force https://github.com/…
80f514c 
…impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "87931221f"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "profile_script"
  commit:   "87931221f"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
Merge remote-tracking branch 'upstream/master' into kernel_286
b444209
git subrepo clone --branch=profile_script --force https://github.com/…
23f6bad 
…impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "be39e592a"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "profile_script"
  commit:   "be39e592a"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
add test for recursive debug breaking debugging
26dacb4
@impact27
Copy link
Contributor Author

I have added a test and a fix for a recursive debug issue

ccordoba12
ccordoba12 reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions for the last test you added, then this should be ready.

spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
impact27 and others added 3 commits March 31, 2023 19:04
@impact27 @ccordoba12
Apply suggestions from code review
24a4576 
Co-authored-by: Carlos Cordoba <[email protected]>
git subrepo clone --branch=profile_script --force https://github.com/…
9522916 
…impact27/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "46fe001dc"
upstream:
  origin:   "https://github.com/impact27/spyder-kernels.git"
  branch:   "profile_script"
  commit:   "46fe001dc"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
git subrepo clone (merge) --branch=master --force https://github.com/…
a29815c 
…spyder-ide/spyder-kernels.git external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "1deda5137"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "master"
  commit:   "1deda5137"
git-subrepo:
  version:  "0.4.5"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "aa416e4"
ccordoba12
ccordoba12 approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here, thanks @impact27!

@ccordoba12 ccordoba12 merged commit 7d15ec2 into spyder-ide:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@impact27 impact27

Labels
component:IPython Console type:Enhancement
Projects
None yet
Milestone
v6.0alpha1
Development

Successfully merging this pull request may close these issues.
2 participants
@impact27 @ccordoba12