Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Wait on all shutdown threads (IPython console) #20562

Merged
merged 3 commits into from
Feb 19, 2023

Conversation

impact27
Copy link
Contributor

Description of Changes

Make sure spyder doesn't quit while some threads are running, leading to a crash

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #20561

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27 for your help with this! Small suggestion for you, otherwise looks good to me.

spyder/plugins/ipythonconsole/utils/kernel_handler.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v6.0alpha1 milestone Feb 19, 2023
@ccordoba12 ccordoba12 changed the title PR: wait on all shutdown threads PR: Wait on all shutdown threads (IPython console) Feb 19, 2023
@ccordoba12 ccordoba12 mentioned this pull request Feb 19, 2023
10 tasks
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 merged commit 6996fb8 into spyder-ide:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spyder crashes at shutdown
2 participants