Skip to content

PR: Fix capitalization on Windows when opening a file in debug mode #20493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 29, 2023
Merged

PR: Fix capitalization on Windows when opening a file in debug mode #20493

merged 6 commits into from
Jul 29, 2023

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Feb 7, 2023 •
edited
Loading

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #12851

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@impact27 impact27 mentioned this pull request Feb 7, 2023
Closed
@impact27 impact27 changed the base branch from 5.x to master February 12, 2023 14:43
@ccordoba12 ccordoba12 added this to the v6.0alpha2 milestone Jul 7, 2023
ccordoba12
ccordoba12 reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions for you @impact27.

Also, please merge with master to re-run our tests again.

@ccordoba12 ccordoba12 changed the title PR: Fix capitalisation when opening a file in debug mode PR: Fix capitalization on Windows when opening a file in debug mode Jul 7, 2023
@ccordoba12
Copy link
Member

@impact27, please merge with master to get the fixes to our tests.

@ccordoba12 ccordoba12 force-pushed the fix_capitalisation branch from 86c8005 to 49336d3 Compare July 29, 2023 14:49
@ccordoba12
Copy link
Member

ccordoba12 commented Jul 29, 2023 •
edited
Loading

@impact27, I rebased this one on top of master so we can merge it.

ccordoba12
ccordoba12 approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 merged commit 3028657 into spyder-ide:master Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@impact27 impact27

Labels
component:Debugger OS:Windows type:Bug
Projects
None yet
Milestone
v6.0alpha2
Development

Successfully merging this pull request may close these issues.

Filenames are lowercased in debug mode
2 participants
@impact27 @ccordoba12