Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix a small kernel restart issue (IPython console) #20238

Merged
merged 2 commits into from
Dec 22, 2022
Merged

PR: Fix a small kernel restart issue (IPython console) #20238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2437653
IPython console: Only close kernel handler if available on shutdown
ccordoba12 Dec 21, 2022
d0ff9de
Testing: Install Spyder-kernels from master in env used to test conda…
ccordoba12 Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ mamba create -n jedi-test-env -q -y python=3.9 flask spyder-kernels
mamba list -n jedi-test-env

# Create environment to test conda activation before launching a spyder kernel
mamba create -n spytest-ž -q -y python=3.9 spyder-kernels
mamba create -n spytest-ž -q -y python=3.9
mamba run -n spytest-ž python -m pip install git+https://github.com/spyder-ide/spyder-kernels.git@master
mamba list -n spytest-ž

# Install pyenv in Posix systems
Expand Down
3 changes: 2 additions & 1 deletion spyder/plugins/ipythonconsole/widgets/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,8 @@ def shutdown(self, shutdown_kernel=True):
if self.shutting_down:
return
self.shutting_down = True
self.kernel_handler.close(shutdown_kernel)
if self.kernel_handler is not None:
self.kernel_handler.close(shutdown_kernel)
super().shutdown()

def reset_kernel_state(self):
Expand Down