Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Move debug functions from IPython plugin to debugger plugin #19265

Merged
merged 8 commits into from
Sep 6, 2022

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Sep 1, 2022

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@pep8speaks
Copy link

pep8speaks commented Sep 1, 2022

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-09-05 16:50:34 UTC

@impact27 impact27 force-pushed the move_ipython branch 2 times, most recently from 6183ad5 to 5204265 Compare September 2, 2022 19:49
Quentin Peter added 2 commits September 3, 2022 19:14
@impact27
Copy link
Contributor Author

impact27 commented Sep 3, 2022

@ccordoba12 this is ready for review

@ccordoba12 ccordoba12 changed the title PR: move debug functions from ipython plugin to debugger plugin PR: Move debug functions from IPython plugin to debugger plugin Sep 3, 2022
@ccordoba12 ccordoba12 added this to the v6.0alpha1 milestone Sep 3, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27! My suggestions are purely stylistic, otherwise looks good to me.

spyder/plugins/debugger/plugin.py Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/plugin.py Show resolved Hide resolved
spyder/plugins/debugger/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/widgets/main_widget.py Outdated Show resolved Hide resolved
@impact27
Copy link
Contributor Author

impact27 commented Sep 5, 2022

@ccordoba12 I just changed sig_pdb_state_changed last-minute because it doesn't make sense to send the filename and line number when the pdb state changes

@impact27
Copy link
Contributor Author

impact27 commented Sep 5, 2022

@ccordoba12 the Create Windows Installer tests are failing here too

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, last minute stylistic suggestions, then this should be ready.

the Create Windows Installer tests are failing here too

Those should be working now.

spyder/plugins/debugger/plugin.py Outdated Show resolved Hide resolved
spyder/plugins/debugger/utils/breakpointsmanager.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 merged commit 0aefa17 into spyder-ide:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants