Skip to content

PR: Do not reset the frames explorer while debugging #18476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 29, 2022

Conversation

impact27
Copy link
Contributor

Description of Changes

After spyder-ide/spyder-kernels#381 the full stack is not sent to the frontend after every pdb command, so executing a command causes the frames explorer to reset. This PR solves that issue and adds a regression test.

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@pep8speaks
Copy link

pep8speaks commented Jun 29, 2022

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-06-29 21:22:46 UTC

@impact27 impact27 changed the title PR: Fix clear pdb and add test PR: Do not reset the frames explorer while debugging Jun 29, 2022
@ccordoba12 ccordoba12 added this to the v6.0alpha1 milestone Jun 29, 2022
@impact27 impact27 force-pushed the fix_frames_explorer branch from 8b33a30 to 86281cd Compare June 29, 2022 17:12
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27! I left some simple suggestions for you, otherwise looks good to me.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 merged commit 6cf8c92 into spyder-ide:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants