Set parent for VarExp editors to fix #5696 so they close with Spyder

spyder-ide · Mar 10, 2018 · 7208279 · 7208279
1 parent 7171f76
commit 7208279
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/spyder/widgets/variableexplorer/collectionseditor.py b/spyder/widgets/variableexplorer/collectionseditor.py
@@ -442,7 +442,7 @@ def createEditor(self, parent, option, index):
                    or not is_known_type(value)
         #---editor = CollectionsEditor
         if isinstance(value, (list, tuple, dict)):
-            editor = CollectionsEditor()
+            editor = CollectionsEditor(parent)
             editor.setup(value, key, icon=self.parent().windowIcon(),
                          readonly=readonly)
             self.create_dialog(editor, dict(model=index.model(), editor=editor,
@@ -472,7 +472,7 @@ def createEditor(self, parent, option, index):
         #--editor = DataFrameEditor
         elif isinstance(value, (DataFrame, DatetimeIndex, Series)) \
           and DataFrame is not FakeObject:
-            editor = DataFrameEditor()
+            editor = DataFrameEditor(parent)
             if not editor.setup_and_check(value, title=key):
                 return
             editor.dataModel.set_format(index.model().dataframe_format)
@@ -494,9 +494,10 @@ def createEditor(self, parent, option, index):
                 return editor
         #---editor = TextEditor
         elif is_text_string(value) and len(value) > 40:
-            te = TextEditor(None)
+            te = TextEditor(None, parent=parent)
             if te.setup_and_check(value):
-                editor = TextEditor(value, key, readonly=readonly)
+                editor = TextEditor(value, key,
+                                    readonly=readonly, parent=parent)
                 self.create_dialog(editor, dict(model=index.model(),
                                                 editor=editor, key=key,
                                                 readonly=readonly))
@@ -517,7 +518,7 @@ def createEditor(self, parent, option, index):
                 return editor
         #---editor = CollectionsEditor for an arbitrary object
         else:
-            editor = CollectionsEditor()
+            editor = CollectionsEditor(parent)
             editor.setup(value, key, icon=self.parent().windowIcon(),
                          readonly=readonly)
             self.create_dialog(editor, dict(model=index.model(), editor=editor,