PR: Improve enum to flags aliasing for PyQt6 and PySide6 > 6.3 and QFileDialog static methods kwarg compatibility
#449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
changed the title
dalthviz
force-pushed
the
enums_flags_pyqt6
branch
from
2150967
to
882d604
Compare
1 task
dalthviz
force-pushed
the
enums_flags_pyqt6
branch
2 times, most recently
from
d0be7fb
to
3664658
Compare
dalthviz
force-pushed
the
enums_flags_pyqt6
branch
from
3664658
to
d389b16
Compare
dalthviz
changed the title
dalthviz
changed the title
QFileDialog static methods kwarg compatibility
dalthviz
changed the title
QFileDialog static methods kwarg compatibilityQFileDialog static methods kwarg compatibility
… kwargs wrapper function in _utils
ccordoba12
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Thanks for your work @dalthviz! It looks good to me, but I have one quick question:
Has this been tested in Napari and works as expected now? I say it because it seems your previous PR was not enough for what they need.
Yep, checks were done and seems like the latest changes here fixed the issues. You can see the feedback for the last changes at napari/napari#6164 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QtWidgets.QFileDialog.Optionsaccess asQtWidgets.QFileDialog.Optionalias (PyQt6) #448 and PR: RestoreQt.ItemFlagsaccess asQt.ItemFlagalias (PyQt6) #444QFileDialogstatic methods (used for compatibility with thedirvsdirectorykwarg specification)Need for changes discovered at napari/napari#6164 (comment) and napari/napari#6164 (comment)