PR: Fix uic skipped tests and PyQt 6.3.0 segfaulting tests#335
Merged
CAM-Gerlach merged 5 commits intospyder-ide:masterfrom Apr 19, 2022
Merged
PR: Fix uic skipped tests and PyQt 6.3.0 segfaulting tests#335CAM-Gerlach merged 5 commits intospyder-ide:masterfrom
CAM-Gerlach merged 5 commits intospyder-ide:masterfrom
Conversation
dalthviz
force-pushed
the
fixes_issue_265
branch
from
55d55ea to
07f285b
Compare
ccordoba12
approved these changes
Apr 12, 2022
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @dalthviz!
CAM-Gerlach
approved these changes
Apr 15, 2022
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Looks great, @dalthviz —always good when we can unskip tests! I had one small tweak to update the skip reason now that it isn't CI-specific, otherwise LGTM
Co-authored-by: CAM Gerlach <[email protected]>
dalthviz
changed the title
dalthviz
force-pushed
the
fixes_issue_265
branch
from
4c8a671 to
fab767a
Compare
CAM-Gerlach
reviewed
Apr 18, 2022
Co-authored-by: CAM Gerlach <[email protected]>
dalthviz
force-pushed
the
fixes_issue_265
branch
2 times, most recently
from
9939841 to
88b3961
Compare
dalthviz
force-pushed
the
fixes_issue_265
branch
from
88b3961 to
6893baf
Compare
CAM-Gerlach
approved these changes
Apr 19, 2022
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
LGTM now, thanks @dalthviz !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #265
Fixes #336