Ignore duplicate modules in ignore list #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore duplicate modules passed in ignore_list. This could also be done with calling `set` on the final ignore list but sets are unordered which in terms of functionality I reckon should be ok but it was a pain in tests, so opted for a this `dict.fromkeys` way since supported python versions are >=3.7
lleontop
force-pushed
the
fix_ignore_duplicates_modules
branch
from
84e6964 to
b5a42db
Compare
lleontop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore duplicate modules passed in ignore_list. This could also be done with calling
seton the final ignore list but sets are unordered which in terms of functionality I reckon should be ok but it was a pain in tests, so opted for a thisdict.fromkeysway since supported python versions are >=3.7fixes: #499