Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup.py from "publish" target #297

Merged
merged 3 commits into from
Jul 1, 2019
Merged

Conversation

pganssle
Copy link
Contributor

@pganssle pganssle commented May 18, 2019

This replaces setup.py upload (which is deprecated and has caused problems for this library before) with twine upload, which is the modern way to do it.

I have also gone ahead and set up PEP 517/518 for this project, and used pep517.build to build the source and binary distributions, thus removing the need to invoke setup.py at all.

This both adds pyproject.toml and switches from setup.py to twine, but if you just want the twine command part of it, the first commit doesn't include the pyproject.toml changes.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 92.969% when pulling 90b8e2a on pganssle:bad_publish into c2d1dd2 on spulec:master.

@pganssle
Copy link
Contributor Author

pganssle commented May 18, 2019

I think the reduction in coverage may be an artifact. I have not touched any .py files, so presumably Makefile or pyproject.toml are being erroneously included in the calculation of coverage percentage, and the fact that they have gotten larger makes the "percentage covered" seem like it fell.

Also, do you want me to add twine and pep517 to requirements.txt? They are only necessary when making releases, which is why I wasn't sure if they should go in the requirements file.

@boxed
Copy link
Contributor

boxed commented May 19, 2019

@pganssle I tend to ignore that check anyway because it's not hugely relevant as you say :)

@spulec spulec merged commit d414467 into spulec:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants