Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ucan 0.10 #510

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

ucan 0.10 #510

wants to merge 42 commits into from

Conversation

chunningham
Copy link
Member

@chunningham chunningham commented Apr 17, 2023 •
edited
Loading

Updates the ucan impl to match the upcoming 0.10 version of the spec. This pr also removes a lot of the IPLD stuff as that will be covered by the cacao crate. Because of this, it removes tracking of the codec and implements verification in tandem with deserialisation so that it can have the original serialisation to verify. It also depends on the as-yet unreleased ucan-capabilities-object crate.

probable TODOs:

  • tests, there are currently no independent 0.10 ucan test vectors that I'm aware of
  • ucan-capabilities-object has to be released

sbihel
sbihel requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review in detail, but it's mostly just removing code.

Could you rebase on latest main?

ssi-ucan/Cargo.toml Outdated Show resolved Hide resolved
ssi-ucan/src/lib.rs Outdated Show resolved Hide resolved
@chunningham chunningham requested a review from sbihel May 1, 2023 18:38
@sbihel
Copy link
Member

sbihel commented May 4, 2023

Looks like some tests are failing

@chunningham
Copy link
Member Author

There's no test vectors anywhere for ucan 0.10, so I wasn't sure which to use. I will generate some.

@chunningham chunningham mentioned this pull request Sep 20, 2023
Open
chunningham and others added 24 commits September 20, 2023 18:29
@chunningham
update ucan to use new capabilities object
a1d0c8f
@chunningham
remove unnecessary bound on to_block
845ee0f
@chunningham
ensure fct de/serializes from/to a map type
849eba3
@chunningham
remove verification which encodes, impl verify_and_decode
22ce76e
@chunningham
remove ipld and codec stuff, only handle ucans without encoding
8d95fac
@chunningham
doc strings and remove weird Facts struct
252211d
@chunningham
use published uco crate
45773fd
@chunningham
update tests, but not test vectors
1c42da1
@chunningham
rename to decode_and_verify, bump crate version
8c217d0
@chunningham
bump ssi-dids dep
f3532a0
@chunningham
add an into_inner fn to help with From impls
36bee5e
@sbihel @chunningham
Fix ssi-ucan dep version
3b9d744
@chunningham
use unpadded challenge
59c6e24
@chunningham
remove unnecessary serde_as usage
7af2648
@chunningham
add simple new fn
2f55825
@chunningham
comments, better custom header handling and fix basic test
ffe7666
@chunningham
the serde_as usage was not unnecessary
627edfe
@chunningham
fix valid/invalid tests
1c4ad2a
@chunningham
add issued_at field
c35e1d5
@chunningham
move ucv from header to body, make time bounds integers
e19e174
@chunningham
impl default for version type
989540c
@chunningham
split up lib into modules
5276b95
@chunningham
derive everything on version
0453c23
@chunningham
derive more, docs and add plain sign fn for utility
1a8b25e
@chunningham chunningham mentioned this pull request Sep 22, 2023
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbihel sbihel Awaiting requested review from sbihel

@timothee-haudebourg timothee-haudebourg Awaiting requested review from timothee-haudebourg

@cobward cobward Awaiting requested review from cobward

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chunningham @sbihel