Use vc-derive-credential to create a derived credential with selectiv… #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefireskater
force-pushed
the
feat/bbs-sig-2
branch
from
9339262
to
ef20bb1
Compare
Open
15 tasks
thefireskater
force-pushed
the
feat/bbs-sig-2
branch
from
ef20bb1
to
2c84161
Compare
…ely disclosed claims and a BBS+ signature vc-derive-credential, when combined with --nonce, now verifies a BBS+ derived credential Check hashes that are revealed from BBS+ derived credential verification with the claims in the derived credential. Turn off canonicalization for now if using BBS+. Update to_nquads_vec to into_nquads_vec, following new conventions
thefireskater
force-pushed
the
feat/bbs-sig-2
branch
2 times, most recently
from
5618074
to
baf3f19
Compare
thefireskater
force-pushed
the
feat/bbs-sig-2
branch
2 times, most recently
from
c639fcb
to
13b4db9
Compare
thefireskater
force-pushed
the
feat/bbs-sig-2
branch
from
13b4db9
to
aaa0d85
Compare
thefireskater
commented
Jun 5, 2023
| algorithm: Algorithm, | ||
| key: &JWK, | ||
| payload: &JWSPayload, | ||
| ) -> Result<Vec<u8>, Error> { |
There was a problem hiding this comment.
May want to refactor this logic into sign_bytes instead.
thefireskater
commented
Jun 5, 2023
| @@ -337,6 +339,21 @@ impl JWK { | |||
| crate::aleo::generate_private_key_jwk().map_err(Error::AleoGeneratePrivateKey) | |||
| } | |||
|
|
|||
| //#[cfg(feature = "bbs")] | |||
There was a problem hiding this comment.
Should probably get this working
thefireskater
commented
Jun 5, 2023
ssi-ldp/src/lib.rs
Outdated
| let Base64urlUInt(pk_bytes) = &okp.public_key; | ||
| PublicKey::try_from(pk_bytes.as_slice()).unwrap() | ||
| } | ||
| _ => unimplemented!(), |
thefireskater
commented
Jun 5, 2023
ssi-ldp/src/lib.rs
Outdated
| let proof_str = header_str.clone() + ".." + bbs_proof_str.as_str(); | ||
|
|
||
| let mut proof_with_new_sig = proof.clone(); | ||
| proof_with_new_sig.jws = Some(proof_str); // todo: change to proof/proofValue |
There was a problem hiding this comment.
Is it necessary to change to proof or proofValue?
thefireskater
commented
Jun 5, 2023
| } | ||
| } | ||
|
|
||
| let hash = sha256(path.as_bytes()); |
There was a problem hiding this comment.
It is worth investigating whether using SHA-256 is a good idea. Perhaps this choice of hash function can be attacked.
thefireskater
commented
Jun 5, 2023
thefireskater
commented
Jun 5, 2023
| document: &(dyn LinkedDataDocument + Sync), | ||
| proof: &Proof, | ||
| context_loader: &mut ContextLoader, | ||
| ) -> Result<JWSPayload, Error> { |
There was a problem hiding this comment.
Probably better to consolidate this with the original to_jws_payload
… during verification, assume all messages revealed, no 0 messages revealed.
thefireskater
force-pushed
the
feat/bbs-sig-2
branch
4 times, most recently
from
71fc668
to
99b8e44
Compare
thefireskater
force-pushed
the
feat/bbs-sig-2
branch
2 times, most recently
from
61a9d71
to
bf53d3e
Compare
thefireskater
force-pushed
the
feat/bbs-sig-2
branch
from
1abff18
to
46f2795
Compare
thefireskater
force-pushed
the
feat/bbs-sig-2
branch
2 times, most recently
from
d2a67b9
to
b9278e1
Compare
thefireskater
force-pushed
the
feat/bbs-sig-2
branch
from
b9278e1
to
4c65a4c
Compare
thefireskater
force-pushed
the
feat/bbs-sig-2
branch
from
4c65a4c
to
f7cb029
Compare
|
|
|
ssi got support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ely disclosed claims and a BBS+ signature
vc-derive-credential, when combined with --nonce, now verifies a BBS+ derived credential
Check hashes that are revealed from BBS+ derived credential verification with the claims in the derived credential. Turn off canonicalization for now if using BBS+.
Update to_nquads_vec to into_nquads_vec, following new conventions