Skip to content
This repository was archived by the owner on Oct 15, 2025. It is now read-only.

[Optional] [LIS-3707] Upstream fetch#11

Merged
ravisanwal merged 7 commits intomasterfrom
upstream_fetch
Jan 25, 2022
Merged

[Optional] [LIS-3707] Upstream fetch#11
ravisanwal merged 7 commits intomasterfrom
upstream_fetch

Conversation

@ravisanwal
Copy link
Copy Markdown

We may still have to replace ${revision} with actual value for sprout multimodule build to work.

hiliev and others added 6 commits August 23, 2021 10:28
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
…nagement (apache#78)

Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
…default versions. (apache#88)

Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
Reviewed-by:  Ian A Wilson
@ravisanwal
Copy link
Copy Markdown
Author

@ianawilson I realized later that you PR is more or less the same. You have a few additions around changing some versions etc.
I created this using git merge upstream master (and resolved a few conflicts)
I would say that the maven commandline in Jenkinsfile was to match ERM stack versions.

Your PR looks good, so this doesn't need to be merged. I'll close this later.

@ianawilson
Copy link
Copy Markdown

ianawilson commented Jan 22, 2022

Hey @ravisanwal, I think it makes sense to use this PR instead of mine, with its rebasing and rolling things back.

If you don't mind updating this with the latest from upstream (should include HBase 2.4) and (EDIT: You already have this and I missed it) bumping the version, maybe to 1.0.2... I'd love to see this merged and released.

@ianawilson ianawilson mentioned this pull request Jan 22, 2022
Co-authored-by: Ian Wilson <ian.wilson@sproutsocial.com>
@ravisanwal ravisanwal merged commit 3bbe4c7 into master Jan 25, 2022
@ravisanwal ravisanwal deleted the upstream_fetch branch August 6, 2024 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants